Translate dashboard panel url error message #27306
Draft
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
21 tasks
steinmn
force-pushed
the
fix-tech-details-in-dashboard-panel-url-error
branch
from
61e6d72 to
4d9f5d6
Compare
bramkragten
requested changes
Oct 29, 2025
| } | ||
| this.closeDialog(); | ||
| } catch (err: any) { | ||
| if (err?.translation_key === "url_already_exists") { |
There was a problem hiding this comment.
We should not use the translation_key to identify errors, if there is a translation_key we should use the backend provided translation.
There was a problem hiding this comment.
Ok, any chance I can get a review on the linked backend PR first? Since the proper frontend solution depends on how it ends up being solved in the backend.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
If the user tries to create a new dashboard with a URL that already exist, the current error message contains technical details and is not translatable (#27162).
This PR uses the translation_key from the updated error message in home-assistant/core#153501 to display an improved translated error message.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: